Skip to content

Conversation

@dotlambda
Copy link
Member

Diff: igraph/igraph@0.10.17...1.0.0

Changelog: https://github.com/igraph/igraph/blob/1.0.0/CHANGELOG.md

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Sep 23, 2025
@dotlambda
Copy link
Member Author

dotlambda commented Sep 24, 2025

At least the following packages are broken by this update:

@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 17, 2025
@dotlambda dotlambda marked this pull request as ready for review October 31, 2025 20:42
@nix-owners nix-owners bot requested a review from jboynyc October 31, 2025 20:43
@nixpkgs-ci nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Oct 31, 2025
@dotlambda
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445482
Commit: 950392067f2a7cde61541b171083ceedd3110d2a


x86_64-linux

❌ 3 packages failed to build:
  • hal-hardware-analyzer
  • python312Packages.textnets
  • python312Packages.textnets.dist
✅ 50 packages built:
  • checkov
  • checkov.dist
  • flattenReferencesGraph
  • flattenReferencesGraph.dist
  • igraph
  • igraph.dev
  • igraph.doc
  • libleidenalg
  • python312Packages.energyflow
  • python312Packages.energyflow.dist
  • python312Packages.explorerscript
  • python312Packages.explorerscript.dist
  • python312Packages.igraph
  • python312Packages.igraph.dist
  • python312Packages.iplotx
  • python312Packages.iplotx.dist
  • python312Packages.kmapper
  • python312Packages.kmapper.dist
  • python312Packages.leidenalg
  • python312Packages.leidenalg.dist
  • python312Packages.scikit-tda
  • python312Packages.scikit-tda.dist
  • python312Packages.skytemple-dtef
  • python312Packages.skytemple-dtef.dist
  • python312Packages.skytemple-files
  • python312Packages.skytemple-files.dist
  • python312Packages.skytemple-ssb-debugger
  • python312Packages.skytemple-ssb-debugger.dist
  • python313Packages.energyflow
  • python313Packages.energyflow.dist
  • python313Packages.explorerscript
  • python313Packages.explorerscript.dist
  • python313Packages.igraph
  • python313Packages.igraph.dist
  • python313Packages.iplotx
  • python313Packages.iplotx.dist
  • python313Packages.kmapper
  • python313Packages.kmapper.dist
  • python313Packages.leidenalg
  • python313Packages.leidenalg.dist
  • python313Packages.scikit-tda
  • python313Packages.scikit-tda.dist
  • python313Packages.skytemple-dtef
  • python313Packages.skytemple-dtef.dist
  • python313Packages.skytemple-files
  • python313Packages.skytemple-files.dist
  • python313Packages.skytemple-ssb-debugger
  • python313Packages.skytemple-ssb-debugger.dist
  • skytemple
  • skytemple.dist

Error logs: `x86_64-linux`
hal-hardware-analyzer
      |                                                                              igraph_vector_int_list_t*
/nix/store/scamh9kpqdnc2hywc804ha7w7ngx31qr-igraph-1.0.0-dev/include/igraph/igraph_paths.h:173:51: note:   initializing argument 2 of 'igraph_error_t igraph_get_all_shortest_paths(const igraph_t*, const igraph_vector_t*, igraph_vector_int_list_t*, igraph_vector_int_list_t*, igraph_vector_int_t*, igraph_int_t, igraph_vs_t, igraph_neimode_t)'
  173 |     const igraph_t *graph, const igraph_vector_t *weights,
      |                            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/build/source/include/hal_core/utilities/result.h:56:5: error: could not convert '{hal::result_constructor_type::ER(), <expression error>}' from '<brace-enclosed initializer list>' to 'hal::Result<std::vector<std::vector<unsigned int> > >'
   56 |     }
      |     ^
      |     |
      |     <brace-enclosed initializer list>
/build/source/plugins/graph_algorithm/src/algorithms/shortest_path.cpp:271:24: note: in expansion of macro 'ERR'
  271 |                 return ERR(igraph_strerror(res));
      |                        ^~~
[1542/2353] Building CXX object plugins/boolean_influence/CMakeFiles/boolean_influence.dir/src/boolean_influence.cpp.o
[1543/2353] Building CXX object plugins/simulator/netlist_simulator_controller/CMakeFiles/netlist_simulator_controller.dir/src/dummy_engine.cpp.o
[1544/2353] Building CXX object plugins/simulator/netlist_simulator_controller/CMakeFiles/netlist_simulator_controller.dir/src/saleae_directory.cpp.o
[1545/2353] Building CXX object plugins/z3_utils/CMakeFiles/z3_utils.dir/python/python_bindings.cpp.o
[1546/2353] Building CXX object plugins/boolean_influence/CMakeFiles/boolean_influence.dir/python/python_bindings.cpp.o
[1547/2353] Building CXX object plugins/simulator/netlist_simulator_controller/CMakeFiles/netlist_simulator_controller.dir/src/plugin_netlist_simulator_controller.cpp.o
[1548/2353] Building CXX object plugins/simulator/netlist_simulator_controller/CMakeFiles/netlist_simulator_controller.dir/src/netlist_simulator_controller.cpp.o
ninja: build stopped: subcommand failed.
python312Packages.textnets
>       assert net.edges["weight"] == loaded.edges["weight"]
E       assert [0.5440680443...43502757, ...] == [0.5440680443...43502757, ...]
E         
E         At index 1 diff: 0.5440680443502757 != 0.24303804868629442
E         Use -v to get more diff

tests/test_textnets.py:198: AssertionError
=============================== warnings summary ===============================
../../nix/store/k1jsd4b49387g8jda9ypn55vdhd9zdh1-python3.12-spacy-3.8.7/lib/python3.12/site-packages/spacy/cli/_util.py:23
/nix/store/k1jsd4b49387g8jda9ypn55vdhd9zdh1-python3.12-spacy-3.8.7/lib/python3.12/site-packages/spacy/cli/_util.py:23: DeprecationWarning: Importing 'parser.split_arg_string' is deprecated, it will only be available in 'shell_completion' in Click 9.0.
from click.parser import split_arg_string

../../nix/store/12c2mjj6jrbwqm1mypk5mm623scv3nxn-python3.12-weasel-0.4.1/lib/python3.12/site-packages/weasel/util/config.py:8
/nix/store/12c2mjj6jrbwqm1mypk5mm623scv3nxn-python3.12-weasel-0.4.1/lib/python3.12/site-packages/weasel/util/config.py:8: DeprecationWarning: Importing 'parser.split_arg_string' is deprecated, it will only be available in 'shell_completion' in Click 9.0.
from click.parser import split_arg_string

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_textnets.py::test_textnet_save_and_load - assert [0.5440680443...43502757, ...] == [0.5440680443...43502757, ...]
================== 1 failed, 30 passed, 2 warnings in 15.77s ===================

@risicle
Copy link
Contributor

risicle commented Oct 31, 2025

Given #421201 there's surely nothing we can do but keep an igraph_0_10

@dotlambda
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445482
Commit: 6bed30996f004cbec520cd1b4ba32b19351b5f61


x86_64-linux

❌ 2 packages failed to build:
  • python312Packages.textnets
  • python312Packages.textnets.dist
✅ 50 packages built:
  • checkov
  • checkov.dist
  • flattenReferencesGraph
  • flattenReferencesGraph.dist
  • igraph
  • igraph.dev
  • igraph.doc
  • libleidenalg
  • python312Packages.energyflow
  • python312Packages.energyflow.dist
  • python312Packages.explorerscript
  • python312Packages.explorerscript.dist
  • python312Packages.igraph
  • python312Packages.igraph.dist
  • python312Packages.iplotx
  • python312Packages.iplotx.dist
  • python312Packages.kmapper
  • python312Packages.kmapper.dist
  • python312Packages.leidenalg
  • python312Packages.leidenalg.dist
  • python312Packages.scikit-tda
  • python312Packages.scikit-tda.dist
  • python312Packages.skytemple-dtef
  • python312Packages.skytemple-dtef.dist
  • python312Packages.skytemple-files
  • python312Packages.skytemple-files.dist
  • python312Packages.skytemple-ssb-debugger
  • python312Packages.skytemple-ssb-debugger.dist
  • python313Packages.energyflow
  • python313Packages.energyflow.dist
  • python313Packages.explorerscript
  • python313Packages.explorerscript.dist
  • python313Packages.igraph
  • python313Packages.igraph.dist
  • python313Packages.iplotx
  • python313Packages.iplotx.dist
  • python313Packages.kmapper
  • python313Packages.kmapper.dist
  • python313Packages.leidenalg
  • python313Packages.leidenalg.dist
  • python313Packages.scikit-tda
  • python313Packages.scikit-tda.dist
  • python313Packages.skytemple-dtef
  • python313Packages.skytemple-dtef.dist
  • python313Packages.skytemple-files
  • python313Packages.skytemple-files.dist
  • python313Packages.skytemple-ssb-debugger
  • python313Packages.skytemple-ssb-debugger.dist
  • skytemple
  • skytemple.dist

Error logs: `x86_64-linux`
python312Packages.textnets
>       assert net.edges["weight"] == loaded.edges["weight"]
E       assert [0.5440680443...43502757, ...] == [0.5440680443...43502757, ...]
E         
E         At index 1 diff: 0.5440680443502757 != 0.24303804868629442
E         Use -v to get more diff

tests/test_textnets.py:198: AssertionError
=============================== warnings summary ===============================
../../nix/store/k1jsd4b49387g8jda9ypn55vdhd9zdh1-python3.12-spacy-3.8.7/lib/python3.12/site-packages/spacy/cli/_util.py:23
/nix/store/k1jsd4b49387g8jda9ypn55vdhd9zdh1-python3.12-spacy-3.8.7/lib/python3.12/site-packages/spacy/cli/_util.py:23: DeprecationWarning: Importing 'parser.split_arg_string' is deprecated, it will only be available in 'shell_completion' in Click 9.0.
from click.parser import split_arg_string

../../nix/store/12c2mjj6jrbwqm1mypk5mm623scv3nxn-python3.12-weasel-0.4.1/lib/python3.12/site-packages/weasel/util/config.py:8
/nix/store/12c2mjj6jrbwqm1mypk5mm623scv3nxn-python3.12-weasel-0.4.1/lib/python3.12/site-packages/weasel/util/config.py:8: DeprecationWarning: Importing 'parser.split_arg_string' is deprecated, it will only be available in 'shell_completion' in Click 9.0.
from click.parser import split_arg_string

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_textnets.py::test_textnet_save_and_load - assert [0.5440680443...43502757, ...] == [0.5440680443...43502757, ...]
=================== 1 failed, 30 passed, 2 warnings in 4.47s ===================

@risicle
Copy link
Contributor

risicle commented Nov 1, 2025

Other than the textnets failure, nixpkgs-review happy, macos 12 x86_64, nixos x86_64 & aarch64-linux.

Also built pkgsCross.aarch64-multiplatform variant on nixos x86_64

@dotlambda
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445482
Commit: 384dc3816109ba11708a1bb810a10a0f9c318d66


x86_64-linux

✅ 52 packages built:
  • checkov
  • checkov.dist
  • flattenReferencesGraph
  • flattenReferencesGraph.dist
  • igraph
  • igraph.dev
  • igraph.doc
  • libleidenalg
  • python312Packages.energyflow
  • python312Packages.energyflow.dist
  • python312Packages.explorerscript
  • python312Packages.explorerscript.dist
  • python312Packages.igraph
  • python312Packages.igraph.dist
  • python312Packages.iplotx
  • python312Packages.iplotx.dist
  • python312Packages.kmapper
  • python312Packages.kmapper.dist
  • python312Packages.leidenalg
  • python312Packages.leidenalg.dist
  • python312Packages.scikit-tda
  • python312Packages.scikit-tda.dist
  • python312Packages.skytemple-dtef
  • python312Packages.skytemple-dtef.dist
  • python312Packages.skytemple-files
  • python312Packages.skytemple-files.dist
  • python312Packages.skytemple-ssb-debugger
  • python312Packages.skytemple-ssb-debugger.dist
  • python312Packages.textnets
  • python312Packages.textnets.dist
  • python313Packages.energyflow
  • python313Packages.energyflow.dist
  • python313Packages.explorerscript
  • python313Packages.explorerscript.dist
  • python313Packages.igraph
  • python313Packages.igraph.dist
  • python313Packages.iplotx
  • python313Packages.iplotx.dist
  • python313Packages.kmapper
  • python313Packages.kmapper.dist
  • python313Packages.leidenalg
  • python313Packages.leidenalg.dist
  • python313Packages.scikit-tda
  • python313Packages.scikit-tda.dist
  • python313Packages.skytemple-dtef
  • python313Packages.skytemple-dtef.dist
  • python313Packages.skytemple-files
  • python313Packages.skytemple-files.dist
  • python313Packages.skytemple-ssb-debugger
  • python313Packages.skytemple-ssb-debugger.dist
  • skytemple
  • skytemple.dist

@dotlambda dotlambda added this pull request to the merge queue Nov 1, 2025
Merged via the queue into NixOS:master with commit 68fe45d Nov 1, 2025
28 of 30 checks passed
@dotlambda dotlambda deleted the igraph branch November 1, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants